Break java installation in separate role

3 files changed, 14 insertions, 7 deletions

diff --git a/roles/minecraft/meta/main.yml b/roles/minecraft/meta/main.yml
new file mode 100644
index 0000000..9866fe9
--- /dev/null
+++ b/roles/minecraft/meta/main.yml
@@ -0,0 +1,8 @@
+
+# minecraft ~~ roles/minecraft/meta/main.yml
+# Meta parameters
+
+---
+
+dependencies:
+  - { role: java, tags: "dependency" }
diff --git a/roles/minecraft/tasks/main.yml b/roles/minecraft/tasks/main.yml
index 657fb60..d78aa6e 100644
--- a/roles/minecraft/tasks/main.yml
+++ b/roles/minecraft/tasks/main.yml
@@ -12,6 +12,7 @@
   user:
     name: "{{ minecraft_user }}"
     group: "{{ minecraft_group }}"
+    system: true
 
 - name: create minecraft directory
   file:
@@ -21,15 +22,12 @@
     mode: 0700
     state: directory
 
-- name: install java package
-  package:
-    name: "{{ packages[os_distribution].java }}"
-
 - name: download minecraft server
   get_url:
     url: "{{ minecraft_url }}"
     dest: "{{ minecraft_dir }}/{{ minecraft_bin }}"
     owner: "{{ minecraft_user }}"
+    mode: 0644
 
 - name: enable eula
   lineinfile:
@@ -45,7 +43,8 @@
   include_role: name=rc
   vars:
     rc_cmd: java
-    rc_args: "-jar -Xms{{ minecraft_ram }} -Xmx{{ minecraft_ram }} -XX:+UseG1GC -jar server.jar nogui"
+    rc_args: "-Xms{{ minecraft_ram }} -Xmx{{ minecraft_ram }} -XX:+UseG1GC -jar server.jar nogui"
     rc_user: "{{ minecraft_user }}:{{ minecraft_group }}"
     rc_dir: "{{ minecraft_dir }}"
     rc_name: minecraft
+    rc_strictpexp: true
diff --git a/roles/minecraft/vars/main.yml b/roles/minecraft/vars/main.yml
index f280e73..d917ac9 100644
--- a/roles/minecraft/vars/main.yml
+++ b/roles/minecraft/vars/main.yml
@@ -3,8 +3,8 @@
 
 ---
 
-minecraft_user: "minecraft"
-minecraft_group: "minecraft"
+minecraft_user: "_minecraft"
+minecraft_group: "_minecraft"
 minecraft_dir: "/data/minecraft"
 minecraft_bin: "server.jar"
 minecraft_ram: "4G"