aboutsummaryrefslogtreecommitdiffstats
path: root/st.c
Commit message (Collapse)AuthorAgeFilesLines
* Remove indentation level in xdrawcursorRoberto E. Vargas Caballero2014-09-091-31/+32
|
* Removing wrapping newlines from selectionBen Hendrickson2014-08-231-2/+5
| | | | | | | | | | | | | | | | When getting selected text, lines that were wrapped because of length ought not include the wrapping newline in the selection. This comes up, for example, when copying a bash command that is long enough to wrap from the console and pasting it back into the console. The extra newline breaks it. Similiarly, changes behavior when trimming whitespace from the end of a physical line to only do so if the line does not wrap. Otherwise we are trimming whitespace from the middle of a logical line, which may change its meaning. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Change the behavior of word snapping on delimitersIvan Delalande2014-08-211-2/+9
| | | | | | | | This makes any sequence of identical delimiters be considered a single word in word-snapping mode. This seems more coherent for this mode and is similar to what xterm does. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Move calls to selsnap into selnormalizeIvan Delalande2014-08-211-11/+3
| | | | | | | | This simplifies getbuttoninfo() and bpress(), and fixes a bug which made word snapping behave incorrectly when a delimiter was at the beginning or end of line. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Improve readability of enum membersAlexander Huemer2014-08-201-32/+32
| | | | | | | | The 'left shift from one' notation of power of two integers is more expressive than the result. Signed-off-by: Alexander Huemer <alexander.huemer@xx.vu> Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Add eschandle()Roberto E. Vargas Caballero2014-08-201-78/+91
| | | | | | | We already have a csihandle() function, where is located code about CSI sequences, so it is logical do the same with ESC sequences. This change helps to simplify tcontrol(), which has a complex flow and should be rewritten.
* Improve execsh() and don't allow anonymous shellsRoberto E. Vargas Caballero2014-08-201-13/+17
| | | | | This patch improves the shell selection on execsh and forbid shell with users don't registered in the passwd file.
* Fix definition of CONTROLC0Roberto E. Vargas Caballero2014-08-191-1/+1
| | | | | | | DEL character is not thecnically talking a C0 control character, although it has some common properties with them, so it is useful for us consider it as C0. Before this patch DEL (\177), was not ignored as it ought to be.
* reset the alt screen in tresetQuentin Carbonneaux2014-08-191-3/+6
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* simplify loop in tresizeQuentin Carbonneaux2014-08-191-4/+2
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fix man page and usage()Roberto E. Vargas Caballero2014-08-171-2/+2
| | | | | | Man page was repeating -f option, the second time instead of -i, and this option was lost in usage() message. This patch also indent the output of usage().
* Convert VT102ID to a config variableRoberto E. Vargas Caballero2014-08-151-5/+3
| | | | | | VT102ID is the sequence that the terminal returns when it is inquired to identify itself. This value should be configurable in the same way that another st parameters.
* Fix portability problem in techo()Roberto E. Vargas Caballero2014-08-151-2/+2
| | | | | | | | | | ISCONTROL chechks if a value is between 0 and 0x1f or between 0x80 and 0x9f. Char signess depends of architecture and compiler, so in some environment the second case is always false (and wrong), Techo() calls ISCONTROL with a char variable, whose type cannot be changed because tpuc() expects a pointer to char, so the solution is to insert a cast in the call to ISCONTROL.
* Don't set dirty all lines because tswapcreen do itnoname2014-08-101-3/+1
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* tresize return value is not usednoname2014-08-101-6/+7
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Unset mode when clearing regionsRoberto E. Vargas Caballero2014-08-071-2/+6
| | | | | | | | | | | | | | tclearregion() was clearing regions using spaces and the current attributes of the terminal. It was correct with all the modes excepct underline, because they didn't affect the space character, but in the case of underline it was a problem. A easy way of seeing this problem is writing this in the last line of the terminal: tput smul ; echo first; tput rmul; echo second; echo third Fist was underlined, and second and third were not underlined, but the spaces at the right of second was underlined becuause in the previous scrool underline mode was set.
* Add error message when child exits whit errorRoberto E. Vargas Caballero2014-08-041-6/+5
| | | | | | Master proccess was not showing any error message when the child died with an error, and it was very confusing for the user (for example with incorrect -e command).
* Remove difference between fast and slow blinkingRoberto E. Vargas Caballero2014-07-311-12/+9
| | | | | | | | | | One blinking mode is good enough, and two is too much. The best aproach is emulate the fast blinking with the slow blinking, that it is more used. It is removed the flag ATTR_FASTBLINK because it has not a different meaning of ATTR_BLINK, so it is not needed. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fix disabling of bold and fastblinkMichael Forney2014-07-261-8/+2
| | | | | | | | | | | | | According to ECMA-48¹ 8.3.117, an attribute value of 21 is "doubly underlined", while 22 is "normal colour or normal intensity (neither bold nor faint)". Additionally, 25 is "steady (not blinking)", which likely means neither slow blink nor fast blink. ¹: http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fix st with input method.Weng Xuetian2014-07-191-0/+2
| | | | | | | XFilterEvent need to be called against every event, otherwise it would missing some message in the xim protocol and misbehave on some im server. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Changed inconsistent indentEric Pruitt2014-07-151-1/+1
| | | | | | | - A line was indented using spaces despite the rest of the code using tabs. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Add 8 bit version of DCS, APC, PM, OSCRoberto E. Vargas Caballero2014-07-081-7/+32
| | | | | DCS, APC, PM, OSC version for 7 bits environments already was implemented in st. This patch adds the 8 bit version of it.
* Add 8 bit version of HTSRoberto E. Vargas Caballero2014-07-081-1/+3
| | | | | HTS version for 7 bits environments already was implemented in st. This patch adds the 8 bit version of it.
* Add 8 bit version of NELRoberto E. Vargas Caballero2014-07-081-1/+4
| | | | | NEL version for 7 bits environments already was implemented in st. This patch adds the 8 bit version of it.
* Add 8 bit version of DECIDRoberto E. Vargas Caballero2014-07-081-1/+4
| | | | | DECID version for 7 bits environments already was implemented in st. This patch adds the 8 bit version of it.
* Render faint attributeAnders Eurenius2014-07-081-1/+9
| | | | | | | | | Faint text is implemented by allocating a new color at one-half intensity of each of the r, g, b components, or if the text bold at the same time, it is not made lighter. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com> Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Remove all strcmp and strlen calls on Glyph.c[]Ivan Delalande2014-07-081-26/+16
| | | | | | | | | | There were a few occurrences of strcmp and strlen being called on Glyph.c[], which is not always null-terminated (this actually depends on the last values in the buffer s in ttyread()). This patch replace all the calls to strcmp with a test on c[0] directly or a call to tlinelen, and the one to strlen with utf8len. I also took the opportunity to refactor getsel and tdumpline. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Render struck-out attributeAnders Eurenius2014-06-271-0/+5
| | | | | | | | Implement crossed-out text with an XftDrawRect call, similar to how underline is implemented. The line is drawn at 2/3 of the font ascent, which seems to work nicely in practice. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Render invisible attributeAnders Eurenius2014-06-271-0/+3
| | | | | | | | | Implement invisible mode by setting the foreground color to be the same as the background color. Not rendering anything would also be an alternative, but this seems less likely to cause surprises in conjunction with any hacks. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Reorder and extend glyph attributesAnders Eurenius2014-06-271-14/+46
| | | | | | | | | | Faint, invisible, struck and fast blink are added as glyph attributes. Since there's an edit here, let's take the opportunity to reorder them so that they correspond to the two's power of the corresponding escape code. (just for neatness, let's hope that property never gets used for anything.) Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Remove CEIL macroRoberto E. Vargas Caballero2014-06-261-3/+3
| | | | | | | | This macro was not correct in some cases, and it was used only in one place, where we did'nt get any benefit in performance of in size, so the macro is removed and ceilf is used instead of it. The only function needed from math.h is ceilf, so this patch defines the prototype of it instead of including math.h.
* Fixed wrong nanosecond factor 10E6.Ivan Delalande2014-06-261-3/+3
| | | | | | | | | | Commit 5edeec1 introduced a wrong factor for nanosecond computation, the correct value is 1E6. Time and timeout values are 10 times less than they should be and this cause high CPU usage. Reported by pyroh on IRC. Thanks! Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Use monotonic clock to prevent timing issuesFRIGN2014-06-241-14/+13
| | | | | | | | | | | | | | This patch replaces the gettimeofday()/timeval-system with uses of clock_gettime() with a monolithic clock and timespec-structs. gettimeofday() is not accurate and prone to jumps and POSIX.1-2008 marks it as obsolete. Read more here [0]. The patch should speak for itself and decreases the binary size for me by almost 200K(!). [0]: http://blog.habets.pp.se/2010/09/gettimeofday-should-never-be-used-to-measure-time Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* update size hints on zoomTroy Sankey2014-06-211-0/+1
| | | | | | | On font zooming (i.e. xzoom()), window size hints are not updated. This patch does that. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Refactor the innermost loop of the xdraws functionSilvan Jegen2014-06-151-20/+14
| | | | | Signed-off-by: Silvan Jegen <s.jegen@gmail.com> Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Style police.Christoph Lohmann2014-06-071-2/+3
|
* Simplify tdeftransRoberto E. Vargas Caballero2014-06-071-10/+5
|
* Remove unnecessary typedefFRIGN2014-06-061-1/+0
| | | | | | | This should also fix compiling-errors on OpenBSD, as reported by Nils R. Thanks! Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Refactor selsnap SNAP_WORD.Colona2014-06-051-23/+21
| | | | | | | | Refactor the SNAP_WORD part in selsnap, and fix a bug that caused the word delimiters to be ignored if it was at the very beginning or end of a wrapped line. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fix rectangular selection.Colona2014-06-041-1/+1
| | | | | | | | | selsort computes the wrong normalized coordinates when rectangular selection is enabled, causing rectangular selection to only work when going toward either the top left corner, or the bottom right one. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* tiny cleanupHiltjo Posthuma2014-06-041-5/+2
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Make selection consistent over line breaks.Colona2014-06-041-20/+26
| | | | | | | | | | | Currently, selection is expanded to the end of the line over line breaks only in regular selection mode, when the line in not empty and when going down and/or right. This covers all the cases including word selection mode, with the exception of rectangular selection because it would make this mode too rigid. This adjustment is made in selsort so I renamed it to selnormalize to better reflect what it does now. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fixing color and refactor xsetcolorname.Christoph Lohmann2014-06-011-38/+50
| | | | | | | | | | | By the recommendation of FRIGN I refactored xsetcolorname to remove the unnecessary r, g, b variables when allocating a new color. Colors are now freed and set to the new color. A die() should not happen here. Oth‐ erwise it is easy for applications to kill st. St should be resilent to malicious input. Second this patch standardises the naming of »color«. There is no »colour« here. Maybe in some parts of the world.
* Revert "Refactor xsetcolorname()"Christoph Lohmann2014-06-011-14/+18
| | | | This reverts commit a32c5f5726f514b49bd396f27aab0e78c40126d3.
* Refactor xsetcolorname()FRIGN2014-06-011-18/+14
| | | | | | | | | | | | | | | I mainly improved the slightly off algorithm used to load colours in the 256-colour-space and removed unnecessary local values (r,g,b,colour). "colour" is not necessary as a punchbag for XftColorAlloc[Value,Name], as they don't mess with the result-adress until they are absolutely sure everything worked out[0]. Being at it, I changed the error-returns for AllocValue to dies (just like in xloadcols()), as a failure is most likely an OOM-situation you better catch early. In case of an invalid name everything stays the same. [0]: http://www.opensource.apple.com/source/X11libs/X11libs-40/libXft/libXft-2.1.13/src/xftcolor.c Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Don't report release events for mouse wheelBalazs Kezes2014-06-011-0/+2
| | | | Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Fixing italic bold.Christoph Lohmann2014-06-011-2/+7
| | | | Thanks Felipe Spychalski <spychalski@gmail.com> for the patch!
* Fixed copying empty lines inside selection.Alexander2014-05-271-1/+1
| | | | | | The code was assuming that empty lines have implicit wrap-around attribute. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fixing trailing whitespaces.Christoph Lohmann2014-05-241-3/+3
|
* Fix colour-model and simplify xloadcols()FRIGN2014-05-241-36/+20
| | | | Signed-off-by: Christoph Lohmann <20h@r-36.net>
remember that computers suck.