diff options
| author | Romain Gonçalves <me@rgoncalves.se> | 2022-12-29 15:42:32 +0100 |
|---|---|---|
| committer | Romain Gonçalves <me@rgoncalves.se> | 2022-12-29 15:54:09 +0100 |
| commit | 1dcac3ff16b9d2d8c0d637d55d75239d86f1f11d (patch) | |
| tree | 21df823719fa23d2ed37dca518ac699d61c42606 | |
| parent | cadc8824e093f37c36263b2aefba3cd680389f0b (diff) | |
| download | rules-1dcac3ff16b9d2d8c0d637d55d75239d86f1f11d.tar.gz | |
refactor(roles/_workstation): enforce changed_when statements
| -rw-r--r-- | roles/_workstation/cronie/tasks/main.yml | 4 | ||||
| -rw-r--r-- | roles/_workstation/dotfiles/tasks/main.yml | 1 | ||||
| -rw-r--r-- | roles/_workstation/libvirt/tasks/main.yml | 3 | ||||
| -rw-r--r-- | roles/_workstation/shell/tasks/main.yml | 1 |
4 files changed, 7 insertions, 2 deletions
diff --git a/roles/_workstation/cronie/tasks/main.yml b/roles/_workstation/cronie/tasks/main.yml index d39abf3..28d2e6f 100644 --- a/roles/_workstation/cronie/tasks/main.yml +++ b/roles/_workstation/cronie/tasks/main.yml @@ -5,8 +5,8 @@ name: cronie state: present -- name: enable and restart cronie +- name: enable and start cronie ansible.builtin.service: name: cronie - state: restarted + state: started enabled: true diff --git a/roles/_workstation/dotfiles/tasks/main.yml b/roles/_workstation/dotfiles/tasks/main.yml index 4b11e3c..50f8d54 100644 --- a/roles/_workstation/dotfiles/tasks/main.yml +++ b/roles/_workstation/dotfiles/tasks/main.yml @@ -25,3 +25,4 @@ when: - dotfiles_bootstrap_result.stat.exists - dotfiles_bootstrap_result.stat.executable + changed_when: false diff --git a/roles/_workstation/libvirt/tasks/main.yml b/roles/_workstation/libvirt/tasks/main.yml index 91b74a2..0563d83 100644 --- a/roles/_workstation/libvirt/tasks/main.yml +++ b/roles/_workstation/libvirt/tasks/main.yml @@ -4,6 +4,9 @@ ansible.builtin.shell: yes | pacman --noprogressbar --needed --sync iptables-nft when: ansible_distribution == "Archlinux" + register: libvirt_result_install_iptables + changed_when: "'there is nothing to do' + not in libvirt_result_install_iptables.stdout" - name: install libvirt ansible.builtin.package: diff --git a/roles/_workstation/shell/tasks/main.yml b/roles/_workstation/shell/tasks/main.yml index 66191e5..3d99574 100644 --- a/roles/_workstation/shell/tasks/main.yml +++ b/roles/_workstation/shell/tasks/main.yml @@ -8,6 +8,7 @@ - name: retrieve zsh path # noqa no-changed-when command-instead-of-shell ansible.builtin.shell: command -v zsh register: shell_zsh_path + changed_when: false - name: ensure zsh is used for workstation user ansible.builtin.user: |