aboutsummaryrefslogtreecommitdiffstats
path: root/st.c
Commit message (Collapse)AuthorAgeFilesLines
* Do not mark as invalid UTF8 control codesRoberto E. Vargas Caballero2015-08-181-2/+2
| | | | | | wcwidth() returns -1 for all the non visible characters, but it doesn't necessarilly mean that they are incorrect. It only means that they are not printable.
* Adding mouse colour/shape settingsAlex Kozadaev2015-07-281-4/+16
|
* Adding -T to the usage too.Christoph Lohmann2015-07-241-2/+4
|
* Add -T, as recommended by Dmitrij D. CzarkoffChristoph Lohmann2015-07-241-0/+1
|
* Fix type for write(2) return variable.Quentin Rameau2015-07-241-1/+2
| | | | | | | | | | | | A little fix in xwrite(). >From 3727d2e3344b57128ab51c7839795204f1f839ff Mon Sep 17 00:00:00 2001 From: Quentin Rameau <quinq@fifth.space> Date: Fri, 24 Jul 2015 11:40:46 +0200 Subject: [PATCH] Fix type for write(2) return variable. The allocated lengh of s fits into an integer so we can safely use ssize_t here.
* Fix style in execshRoberto E. Vargas Caballero2015-07-241-2/+1
|
* Make the comment for the IM XFilter more understandable.Christoph Lohmann2015-07-101-3/+3
|
* Return style unification.Christoph Lohmann2015-07-101-0/+10
|
* Aligning the macros.Christoph Lohmann2015-07-101-20/+22
|
* Unix end of file.Christoph Lohmann2015-07-101-0/+1
|
* No inline declarations please.Christoph Lohmann2015-07-101-2/+2
|
* Typo and the missing incr atom from the patches.Christoph Lohmann2015-07-101-1/+3
|
* Implement chunked write to the cmdfd.Christoph Lohmann2015-07-101-2/+51
| | | | | This is needed so big input like a paste of several megabyte does not clog our I/O.
* Implement INCR transfers in the clipboard.Christoph Lohmann2015-07-101-6/+68
|
* Don't treat clauses like functionsFRIGN2015-07-101-382/+382
| | | | | | and add a space between the keyword and the parentheses. Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Use BSD-style function notationFRIGN2015-07-101-129/+256
| | | | | | | Put the opening brace on a new line. This was already used for some functions inside st.c. Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Unboolify stFRIGN2015-07-091-29/+27
| | | | | | | | | This practice proved itself in sbase, ubase and a couple of other projects. Also remove the True and False defined in X11 and FcTrue and FcFalse defined in Fontconfig. Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Remove insane *_FILENO and EXIT_* usageFRIGN2015-07-091-14/+12
| | | | | | | | | | | | Any system having different assignments than the usual 0, 1, 2 for the standard file numbers and 0, 1 for the exit-statuses is broken beyond repair. Let's keep it simple and just use the numbers, no reason to fall out of the window here and bend down for POSIX. In one occasion, the ret-variable was not necessary. The check was rewritten. Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Revert "Remove unnecessary XFilterEvent call."Weng Xuetian2015-07-021-0/+7
| | | | This reverts commit d2937b05aed9cee8d6651cd806d31682a853c773.
* do not truncate font size when zoomingQuentin Rameau2015-06-191-8/+7
|
* Revert "Optimize memory footprint of line buffers"Roberto E. Vargas Caballero2015-06-031-2/+2
| | | | | This reverts commit 7ab6c92e18d468968811256e808b02309c160a22. We need 32 bits for real color support.
* Support UTF-8 characters as word delimitersJan Christoph Ebersbach2015-05-251-1/+17
| | | | | | | For a higher usefulness of the utf8strchr function, the index of the UTF-8 character could be returned in addition with a Rune instead of a char*. Since utf8strchr is currently only used by ISDELIM I didn't bother to increase the complexity.
* Merge branch 'master' of ssh://suckless.org/gitrepos/stRoberto E. Vargas Caballero2015-05-151-1/+1
|\
| * Fix the new -e handling. An empty cmd has to work for backwards compatibility.Christoph Lohmann2015-05-101-1/+1
| |
* | set selection to IDLE on clearv4hn2015-05-151-0/+1
| | | | | | | | | | | | Otherwise a tangling bmotion event will consider the selection still valid and selnormalize segfaults because of an invalid sel.ob.y index.
* | Small bugfix for makeglyphfontspecs call in drawregionsuigin2015-05-121-1/+1
|/ | | | | | | | | Here's a patch that fixes a bug when calling `makedrawglyphfontspecs' in `drawregion'. Wasn't offseting the pointer into the input glyphs array by `x1'. The bug isn't causing any problems currently, because `drawregion' is always called with `x1' and `y1' values of 0, but if this ever changes in the future, the bug would certainly cause some problems.
* Clean up xdraws and optimize glyph drawing with non-unit kerning valuessuigin2015-05-071-196/+187
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have another patch here for review that optimizes the performance of glyph drawing, primarily when using non-unit kerning values, and fixes a few other minor issues. It's dependent on the earlier patch from me that stores unicode codepoints in a Rune type, typedef'd to uint_least32_t. This patch is a pretty big change to xdraws so your scrutiny is appreciated. First, some performance numbers. I used Yu-Jie Lin termfps.sh shell script to benchmark before and after, and you can find it in the attachments. On my Kaveri A10 7850k machine, I get the following results: Before Patch ============ 1) Font: "Liberation Mono:pixelsize=12:antialias=false:autohint=false" cwscale: 1.0, chscale: 1.0 For 273x83 100 frames. Elapsed time : 1.553 Frames/second: 64.352 Chars /second: 1,458,159 2) Font: "Inconsolata:pixelsize=14:antialias=true:autohint=true" cwscale: 1.001, chscale: 1.001 For 239x73 100 frames. Elapsed time : 159.286 Frames/second: 0.627 Chars /second: 10,953 After Patch =========== 3) Font: "Liberation Mono:pixelsize=12:antialias=false:autohint=false" cwscale: 1.0, chscale: 1.0 For 273x83 100 frames. Elapsed time : 1.544 Frames/second: 64.728 Chars /second: 1,466,690 4) Font: "Inconsolata:pixelsize=14:antialias=true:autohint=true" cwscale: 1.001, chscale: 1.001 For 239x73 100 frames. Elapsed time : 1.955 Frames/second: 51.146 Chars /second: 892,361 As you can see, while the improvements for fonts with unit-kerning is marginal, there's a huge ~81x performance increase with the patch when using kerning values other than 1.0. So what does the patch do? The `xdraws' function would render each glyph one at a time if non-unit kerning values were configured, and this was the primary cause of the slow down. Xft provides a handful of functions which allow you to render multiple characters or glyphs at time, each with a unique <x,y> position, so it was simply a matter of massaging the data into a format that would allow us to use one of these functions. I've split `xdraws' up into two functions. In the first pass with `xmakeglyphfontspecs' it will iterate over all of the glyphs in a given row and it will build up an array of corresponding XftGlyphFontSpec records. Much of the old logic for resolving fonts for glyphs using Xft and fontconfig went into this function. The second pass is done with `xrenderglyphfontspecs' which contains the old logic for determining colors, clearing the background, and finally rendering the array of XftGlyphFontSpec records. There's a couple of other things that have been improved by this patch. For instance, the UTF-32 codepoints in the Line's were being re-encoded back into UTF-8 strings to be passed to `xdraws' which in turn would then decode back to UTF-32 to verify that the Font contained a matching glyph for the code point. Next, the UTF-8 string was being passed to `XftDrawStringUtf8' which internally mallocs a scratch buffer and decodes back to UTF-32 and does the lookup of the glyphs all over again. This patch gets rid of all of this redundant round-trip encoding and decoding of characters to be rendered and only looks up the glyph index once (per font) during the font resolution phase. So this is probably what's responsible for the marginal improvements seen when kerning values are kept to 1.0. I imagine there are other performance improvements here too, not seen in the above benchmarks, if the user has lots of non-ASCII code plane characters on the screen, or several different fonts are being utilized during screen redraw. Anyway, if you see any problems, please let me know and I can fix them.
* Changed type for UTF-32 codepoints from long to uint_least32_tsuigin2015-05-061-25/+27
|
* Fix empty selection highlighting bug.noname2015-05-041-7/+5
| | | | | | | | | | | | | | When user clicks LMB, one character is selected, but will not be copied to selection until the user moves cursor a bit. Therefore, the character should not be highlighted as selected yet. Before the patch, the trick was not to mark line as dirty to avoid highlighting it. However, if user has already selected something and clicks in line that contains selection, selclear sets the line as dirty and one character is highlighted when it should not. This patch replaces dirty trick with explicit check for sel.mode inside selected().
* Fix indentation.noname2015-05-041-4/+4
|
* Add enumeration for sel.modenoname2015-05-041-9/+14
| | | | | | This patch also prevents sel.mode from increasing beyond 2. It is almost impossible, but sel.mode may overflow if mouse is moved around for too long while selecting.
* selnormalize: make special case explicitnoname2015-05-041-4/+4
| | | | | Special case is when regular selection spans multiple lines. Otherwise, just sort sel.ob.x and sel.ob.y.
* selsnap: simplify SNAP_LINE casenoname2015-05-041-3/+3
| | | | | Also make sure y never exceeds term.row-1 even if ATTR_WRAP is set for some reason.
* Remove first argument of selsnap.noname2015-05-041-5/+5
|
* Fix sigchldJochen Sprickerhof2015-05-041-1/+5
| | | | Only wait for termination of the shell.
* len assignment is never usedmvdan@mvdan.cc2015-04-271-1/+0
| | | | Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
* Clarify calculation precedence for '&' and '?'mvdan@mvdan.cc2015-04-271-3/+3
| | | | Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
* Use %u for uintmvdan@mvdan.cc2015-04-271-1/+1
| | | | Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
* Optimize memory footprint of line bufferssuigin2015-04-271-2/+2
|
* Make tputc, tsetchar and techo accept unicodenoname@inventati.org2015-04-271-62/+45
|
* Change internal character representation.noname@inventati.org2015-04-271-38/+35
|
* Remove last parameter of utf8encodenoname@inventati.org2015-04-271-5/+5
| | | | | This parameter was always UTF_SIZ, so it is better remove it and use directly UTF_SIZ in it.
* Use utf8len instead of utf8decode.noname@inventati.org2015-04-271-2/+1
|
* Make build shut up about system() without return value check.alp@alexpilon.ca2015-04-271-1/+2
| | | | | | | | | st.c:1321:2: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result] system(cmd); ^~~~~~ ~~~ Debatable whether an error here should case exit(EXIT_FAILURE). Just preserving the existing behaviour for now.
* Merge remote-tracking branch 'origin/master'Roberto E. Vargas Caballero2015-04-231-54/+30
|\
| * Move common code to xloadcolornoname@inventati.org2015-04-211-53/+29
| |
| * Use LEN(dc.col) instead of LEN(colorname).noname@inventati.org2015-04-211-2/+2
| | | | | | | | LEN(colorname) may be below 256 for some configurations.
* | Fix segmentation fault in strhandle()Roberto E. Vargas Caballero2015-04-231-2/+1
| | | | | | | | | | We cannot pass strescseq.args[0] to atoi when nargs is zero, because in this case it will be null.
* | Uses a &[] pointer loop instead of + pointer loopRoberto E. Vargas Caballero2015-04-231-1/+1
| |
* | Do not set terminal title based on stty arguments.noname@inventati.org2015-04-231-1/+1
|/
remember that computers suck.