aboutsummaryrefslogtreecommitdiffstats
path: root/st.c
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix some bugs in mouse tracking logicMichael Forney2013-09-131-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Button number in X10 mode: I believe the button - 1 came from "C b is button - 1" from [0]. However, above this section, it states "Normally, parameters (such as pointer poisition and button number) for all mouse tracking escape sequences generated by xterm encode numeric parameters in a single character as value+32. For example, ! specifies the value 1." Also, from the description of SGR, "The encoded button value in this case does not add 32 since that was useful only in the X10 scheme for ensuring that the byte containing the button value is a printable code." This suggests that we should still add 32 to the button value when in MODE_MOUSEX10. * No button release reporting in X10 mode: "X10 compatibility mode sends an escape sequence only on button press, encoding the location and the mouse button pressed." * Fix MODE_MOUSEMOTION: Currently, motion reporting is skipped when oldbutton == 3 (corresponding to no button being pressed). However, oldbutton is only set on a button press, which will never be 3. [0]: http://invisible-island.net/xterm/ctlseqs/ctlseqs.html
* Add audible bellRoberto E. Vargas Caballero2013-09-121-0/+2
| | | | | | | | \a is the character for bell, and st is only marking the window as urgent if it is not active. This patch adds an audible bell which can be disable with bellvolume variable. Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Wide character support.Christoph Lohmann2013-09-071-16/+68
| | | | Thanks "Eon S. Jeon" <esjeon@hyunmu.am>!
* Correctly initialize altscreen when defaultbg is not 0.Mark Edgar2013-09-041-14/+3
| | | | | | | | | | | | | | | | | The alternate screen is not properly initialized when st starts. To see this, set defaultbg in config.h to anything other than 0 (for example, swap defaultfg and defaultbg), and run: ./st -e sh -c 'tput smcup; read' You should see that the top-left 80x24 rectangle is black (or whatever colorname[0] is), while the rest of the screen (if any) has the desired colorname[defaultbg] color. The attached patch fixes this by initializing term.c.attr in tnew() before calling tresize(). It also removes the unnecessary xcalloc() calls, which misled me on this bug hunt since it is really tclearregion() which initializes term.lines and term.alt in tresize().
* Regarding commit 7e3cff3Eon S. Jeon2013-08-301-3/+3
| | | | | | | | | | | | | | | | | | Hello. I reviewed and tested commit 7e3cff3, and made a patch that fixes some problems in it. 1. There's a semicolon after an if statement, which is obviously a typo. 2. The current way of calculating text position in "xdraws" yields inconsistent results in some cases. This is due to the use of "font->width", which varies. Instead, "xw.cw" has to be used as the character width. Sincerely, Eon
* Correcting the bitmask value check.Christoph Lohmann2013-08-201-1/+1
|
* Fix signess of tdefcolorEon S. Jeon2013-08-061-3/+3
| | | | | | tdefcolor() returns -1 on error, while its return type is unsigned long. At the same time, line 1724 and 1731 are checking the positivity of its unsigned return value.
* Fixed memory leak in xsettitle().Alexander Sedov2013-08-051-0/+1
|
* Fix blink mode checkMichael Forney2013-08-051-2/+2
| | | | ATTR_BLINK is an attribute for a Glyph and will not be set in term.mode.
* Use character size scaling factorsEric Pruitt2013-08-051-7/+13
| | | | | The bounding boxes for characters can be scaled using "cwscale" and "chscale" to scale the width and height respectively.
* Reload colors in resetRoberto E. Vargas Caballero2013-07-201-0/+9
| | | | | | | | | | | Colors definition can be changed using a OSC sequence, so we have to reload them if we want be sure all the colors are the correct. Could be desirable free the colors allocated due to rgb colors and inverse colors (XftColorAllocValues in xdraws), but it is impossible due we use the same structure for all of them.
* Add RGB color definitionRoberto E. Vargas Caballero2013-07-201-34/+85
| | | | | | This patch uses the bit 24 in the color descriptor as an indicator of RGB color, so we can take the values and generating the XftColour directly in xdraws.
* Improved font cachingEon S. Jeon2013-07-191-41/+22
| | | | | | | | | | | | | | | | | | | | I made a patch that improves the performance of font caching mechanism. This is based on a funny behaviour of FontConfig: it was handling FcCharSet in a somewhat unexpected way. So, we are currently adding "a character" to a new FcCharSet, and then add it to a FcPattern. However, if we toss the FcPattern to FontConfig, it loads the entire language(charset) that contains the character we gave. That is, we don't always have to load a new font for each unknown character. Instead, we can reused cached fonts, and this significantly reduces the number of calls to extremely slow FontConfig matching functions. One more thing. I found that, in libXft, there's a function called XftCharExists. XftCharIndex internally calls this function, and does more stuffs if the character does exist. Since the returned index is never used in st, we should call XftCharExists instead of XftCharIndex. Please note that I already made this change in the patch.
* fix: whitespaceMarkus Teich2013-07-041-62/+62
|
* Remove long text being cropped/wrapped to standard 80x24 on launch.Alexander Sedov2013-07-041-3/+18
| | | | | | | To be more specific, now tty creation is delayed until X window is actually mapped; last ConfigureNotify before mapping determines initial tty size. Please report problems if there are any.
* fix: consistent usage of bitmask operations on unicode functionsMarkus Teich2013-07-041-27/+23
|
* fix: do not need an extra variable for a single readMarkus Teich2013-07-041-4/+1
|
* Fix match function bugsRoberto E. Vargas Caballero2013-07-041-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were two problems with match denfinition. 1) There was a forward declaration in the form: static inline bool match(uint, uint); but later the function was defined as: inline bool match(uint mask, uint state) { This causes that there were two different functions in the code, one local and inline, and other inline but extern. All was working without problems due to we were using -Os, and the compiler was using the extern definition and it was no expanding the static declaration. If you removed the -Os flag, then you got linker errors due it was no able to find the static definition of the static declaration. 2) The mask checking was incorrect because we were doing the test: (state & mask) != state and this test only was saying that at least all the enabled bits of state were enabled also in mask, but no all the possible bits in mask. This was the origin of the bug reported by Xavier Cartron, where he said it was possible activated some shortcuts with some of the modifiers defined in the config.h file.
* Remove unneded call to drawRoberto E. Vargas Caballero2013-07-041-1/+0
| | | | | | draw is the function which update the Xwindow with the information st has, and it is designed in a way that it must be called once in the main loop (run function), and calling it in other places it is a waste of time.
* Fix selection clearingRoberto E. Vargas Caballero2013-07-041-9/+5
| | | | | | | | | The way st knows if there is a selection activated is checking if sel.ob.x is equal to -1. In some parts of the code the way of disabling the selection was only setting it to -1, but after it you can't be sure if the selection is clearing from the terminal representation, because it is necessary mark all the lines affected by the selection as dirty. Already there is a functon which perform this task, selclear.
* Fixing title setting with the title argument.Christoph Lohmann2013-06-091-1/+1
|
* Adding xterm behaviour to setting the title.Christoph Lohmann2013-06-061-1/+8
| | | | Thanks Airwave!
* Adding true mouse motion support.Christoph Lohmann2013-06-011-32/+55
|
* This is a shorter bit handling in MODE_MOUSE.Christoph Lohmann2013-06-011-2/+1
|
* Add some comments about the other mouse reporting modes.Christoph Lohmann2013-06-011-1/+8
|
* Implementing mouse focus and all events.Christoph Lohmann2013-06-011-0/+15
|
* Fixing bad highlighting on first SNAP_WORD multiline select.Christoph Lohmann2013-06-011-3/+2
|
* Fixing the selection in a single line again.Christoph Lohmann2013-05-261-3/+8
| | | | Thanks p37sitdu@lavabit.com!
* Fixing the selection scrolling and the selection naming.Christoph Lohmann2013-05-261-85/+89
| | | | Thanks p37sitdu@lavabit.com!
* Lazy font unloading too.Christoph Lohmann2013-05-111-12/+13
|
* Lazy fontset loading.Christoph Lohmann2013-05-111-6/+15
| | | | Thanks Johannes Hofmann <Johannes.Hofmann@gmx.de>!
* Removing an old select() regression.Christoph Lohmann2013-05-061-14/+12
|
* Allow more complex delimiters for word selections.Christoph Lohmann2013-05-041-1/+3
| | | | Thanks Alexander Rezinsky <alexrez@gmail.com>!
* Expand the last line with '\n' in case of overselection.Christoph Lohmann2013-05-041-1/+16
| | | | Thanks Alexander Rezinsky <alexrez@gmail.com>!
* Select to the end of row if end of line is reached.Christoph Lohmann2013-05-041-0/+12
| | | | Thanks Alexander Rezinsky <alexrez@gmail.com>!
* Better comments for the snapping code.Christoph Lohmann2013-05-041-0/+9
|
* More stable blinking.Christoph Lohmann2013-05-011-2/+9
|
* Selection snapping is now considering wrapping.Christoph Lohmann2013-04-281-3/+39
| | | | Thanks Alexander Rezinsky <alexrez@gmail.com> for mentioning this!
* Add a possibility to modify the string sent by mouse buttons.Christoph Lohmann2013-04-281-5/+21
| | | | Thanks Alexander Rezinsky <alexrez@gmail.com> for the suggestion!
* Be more efficient in blinking.Christoph Lohmann2013-04-261-3/+7
|
* Enable blinking in st.Christoph Lohmann2013-04-261-13/+70
|
* Fixing the selection handling to allow one char selection.Christoph Lohmann2013-04-251-10/+9
| | | | Thanks Alexander Sedov <alex0player@gmail.com> for suggesting the fix!
* Fixing the selection issue in altscreens.Christoph Lohmann2013-04-241-3/+3
|
* Removed redundant check in draw code.Alexander Sedov2013-04-241-1/+1
| | | | | | | We're now clearing empty areas with spaces, so there is no point to check if character contains non-empty string. Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Fix selecting clearing and BCERoberto E. Vargas Caballero2013-04-231-1/+3
| | | | | | | | | | The commit b78c5085f72 changed the st behaviour enabling BCE capability, that means erase regions using background color. Problem comes when you clear a region with a selection, because in this case the real mode of the Glyph is not the value of term.line[y][x], due in drawregion we had enabled the ATTR_REVERSE bit. Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Now clipping is more clear.Christoph Lohmann2013-04-231-0/+2
|
* Removing the overdrawing of some fonts.Christoph Lohmann2013-04-231-0/+11
|
* Implementing 8 bit mode for meta.Christoph Lohmann2013-04-231-4/+19
|
* Adding wrap handling in selection.Christoph Lohmann2013-04-211-14/+23
|
* Added support for double/triple click+dragging.Alexander Sedov2013-04-201-27/+63
| | | | | | | | | Now double-click+dragging automatically snaps both ends to word boundaries (unless on series of spaces), and triple-click selects whole lines. As a side effect, snapping now occurs on button press, not button release like it previously was, but I hope that won't be inconvenient for anyone. Signed-off-by: Christoph Lohmann <20h@r-36.net>
remember that computers suck.