aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move terminal-related selection logic into st.cDevin J. Pohly2018-02-253-41/+54
| | | | | | | | | | | The front-end determines information about mouse clicks and motion, and the terminal handles the actual selection start/extend/dirty logic by row and column. While we're in the neighborhood, we'll also rename getbuttoninfo() to mousesel() which is, at least, less wrong. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move X-specific selection info into XSelectionDevin J. Pohly2018-02-253-21/+19
| | | | | | | Data about PRIMARY/CLIPBOARD and clicks are part of the front-end, not the terminal. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Have selected() check whether selection existsDevin J. Pohly2018-02-252-7/+6
| | | | Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Rely on ttyresize to set tty sizeDevin J. Pohly2018-02-252-6/+3
| | | | | | | | This removes ttynew's dependency on cresize being called first, and then allows us to absorb the ttyresize call into cresize (which always precedes it). Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Remove X and fontconfig from st.cDevin J. Pohly2018-02-253-10/+5
| | | | | | | None of the X-related includes are needed any longer. In addition, move the X modifier defines into x.c, as they are not used outside. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Remove Time argument from xsetselDevin J. Pohly2018-02-253-11/+11
| | | | | | | | | This is an X type and should be internal to x.c. The selcopy() function was a single line and only used in one place, so it was inlined to reduce LOC. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Make win variable internal to x.cDevin J. Pohly2018-02-254-6/+13
| | | | | | | There was only a single reference to the `win` variable in st.c, so exporting that to x.c allows us to rid ourselves of another extern. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move X-related config.h types into x.cDevin J. Pohly2018-02-252-23/+24
| | | | | | No need to expose Shortcut, MouseShortcut, and Key anymore. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Remove unneeded array-length variablesDevin J. Pohly2018-02-251-15/+7
| | | | | | | These were only used in x.c, which now has direct visibility of the config.h arrays. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Inline clipboard functionsDevin J. Pohly2018-02-252-33/+19
| | | | | | | No need to keep a function that only calls another function in the same file. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move config.h include from st.c to x.cDevin J. Pohly2018-02-255-119/+91
| | | | | | | | config.h includes references to KeySyms and other X stuff. Until we come up with a cleaner way to separate configuration, it is simpler (leads to more code removal) to have this here. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Factor out equivalent code from ttyread/ttysendDevin J. Pohly2018-02-252-62/+41
| | | | | | | | | | | | The echo-to-terminal portions of ttyread and ttysend were actually doing the same thing. New function twrite() now handles this. The parameter show_ctrl determines whether control characters are shown as "^A". This was the only difference between tputc and techo, and techo is now unused and removed. (This commit should not change st's behaviour.) Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move opt_* into same file as main()/run()Devin J. Pohly2018-02-253-40/+33
| | | | | | | | This commit is purely about reducing externs and LOC. If the main and run functions ever move elsewhere (which will probably make sense eventually), these should come along with them. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move key-matching functions into x.cDevin J. Pohly2018-02-254-62/+68
| | | | | | | | Modifiers and keysyms are specific to X, and the functions match and kmap are only used in x.c. Needed to global-ize the key arrays and lengths from config.h (for now). Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Pass new dimensions into ttyresizeDevin J. Pohly2018-02-253-7/+7
| | | | | | This removes another reference to TermWindow from st.c. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move window-manipulating functions into x.cDevin J. Pohly2018-02-254-46/+45
| | | | | | xresize is now internal to x.c Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move font/fontspec variables into x.c and XWindowDevin J. Pohly2018-02-253-22/+15
| | | | Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move window urgency handling entirely into x.cDevin J. Pohly2018-02-255-9/+10
| | | | | | This allows us to make xseturgency internal. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move zoom functions into x.cDevin J. Pohly2018-02-254-40/+39
| | | | | | | This makes x(un)loadfonts internal to x.c. Needed to reorder includes and move a typedef to keep the compiler happy. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move usage() to be with run() in x.cDevin J. Pohly2018-02-254-19/+18
| | | | | | run/usage/xinit are now all internal to x.c Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Call xsetenv() in main process instead of childDevin J. Pohly2018-02-253-14/+4
| | | | | | | | | This makes xsetenv internal to x.c, and allows iso14755's external command to use $WINDOWID instead of having to snprintf it again. (The same benefit will apply to the externalpipe patch.) The xwinid function is no longer needed. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Fix color with FAINT attributeBenno Fünfstück2017-12-261-0/+1
| | | | The alpha value needs to be initialized as well.
* Apply ATTR_REVERSE after ATTR_FAINTBenno Fünfstück2017-12-261-6/+7
| | | | | | | | | | | | | | | | An example where the new behaviour makes more sense: Suppose some text is formatted with ATTR_FAINT for red for the foreground, so it is rendered in a dark red. In that case, when selected with the mouse, the intended behaviour is that foreground and background color are swapped: so the selection should be rendered in dark red and the text in the default background color. Before this patch, what happened was that the selection would be in normal red and the text in the darkened background color, making it almost unreadable. For an example application that uses the FAINT attribute, try dmesg from util-linux with color support, it uses FAINT for segfault messages.
* Fix FAQ typoGeorge Ornbo2017-12-211-1/+1
|
* Fix manpage typoParide Legovini2017-10-101-1/+1
| | | | Signed-off-by: Paride Legovini <pl@ninthfloor.org>
* Add an error for XftFontOpenPattern failure.Gary Allen Vollink2017-09-151-0/+3
|
* Revert "Revert "fixed STLDFLAG order in broken st Makefile""Hiltjo Posthuma2017-09-151-1/+1
| | | | | | | | | | This reverts commit 274d46ace00003d1df718b974d17642cbce167d5. Sorry, the original commit was correct after all. It allows has the correct link order and supports static-linking also. Just a reminder: it is important to give a (brief) rationale of the patch intentions.
* base64dec: skip non-printable characters like \r\nSuraj N. Kurapati2017-09-151-5/+12
| | | | | | | | Non-printable characters, such as line breaks, in a base64 encoded string violate the "string length must be a multiple of four" rule. This patch pads the result buffer by one extra unit of four bytes, and skips over non-printable characters found in the input string.
* Revert "fixed STLDFLAG order in broken st Makefile"Hiltjo Posthuma2017-09-131-1/+1
| | | | | | | | This reverts commit 7f990328e4fec8dfaaad311cb8af2304b58c872e. this was wrong as pointed out by k0ga: "STLDFLAGS is about flags to the linker, for example -L not about -l for that reason it must go before the object list".
* Revert "make clipboard patch obsolete"Hiltjo Posthuma2017-09-021-1/+0
| | | | | | | This reverts commit 77c51c5a6b16387f1792e23acbcf2080f790aa25. Having multiple clipboards are useful, for example for plumber scripts. I've discussed this on IRC and it is useful to have.
* make clipboard patch obsoleteAnselm R Garbe2017-09-011-0/+1
|
* fixed STLDFLAG order in broken st MakefileAnselm R Garbe2017-07-231-1/+1
|
* Revert "Add bold off SGR"Quentin Rameau2017-07-121-3/+0
| | | | | This reverts commit 6cb6d61525931c88971cce323f63e40451a6d365. This wasn't a useful thing after all.
* Add dim/smxx/rmxx to terminfo, remove duplicate kich1Quentin Rameau2017-07-121-2/+5
|
* Let the user specify C and LD FLAGSQuentin Rameau2017-07-122-6/+6
|
* Do not obfuscate what make is doing.Quentin Rameau2017-07-122-41/+33
| | | | Change some styling too while we're at it.
* Add color change terminfo capabilitiesMarc André Tanner2017-06-031-0/+3
|
* Add bold off SGRQuentin Rameau2017-06-031-0/+3
|
* st.1: modify man page to accurately reflect default keybindingsgreg.reagle@umbc.edu2017-04-101-10/+7
| | | | | | | | | | | | | Attached. ===> 2/ (text/x-patch) [file] cp /mail/fs/mbox/298/2/body /usr/k0ga/0001-st.1-modify-man-page-to-accurately-reflect-default-k.patch From 265db94b1eca5850d484f86b7db4af8e57822cfe Mon Sep 17 00:00:00 2001 From: Greg Reagle <greg.reagle@umbc.edu> Date: Sun, 9 Apr 2017 23:05:47 -0400 Subject: [PATCH] st.1: modify man page to accurately reflect default keybindings
* Simplify how we keep ATTRs under cursorQuentin Rameau2017-04-041-3/+2
| | | | Thanks to tarug0 for the suggestion/patch.
* Fix commented out codeAlexander Krotov2017-03-291-1/+1
|
* keep some glyph modes for the cursorNils Reuße2017-03-291-0/+3
| | | | | | | | | | | | | st currently does not keep any mode for the cursor that was active in the underlying glyph (e.g. italic text), the mode is always ATTR_NULL [1]. At [2] you can find a screenshot that shows the implications. Other terminals (at least vte-based, such as XFCE-terminal) keep some modes for the cursor. I find the current behaviour very disruptive, so here is a patch that keeps a few (arbitrarily chosen) modes for the cursor. [1] http://git.suckless.org/st/tree/st.c#n3963 [2] http://i.imgur.com/R2yCEaC.png
* Support xterm Ms feature to set clipboardosandov@osandov.com2017-03-194-1/+59
| | | | This is used by, e.g., tmux.
* Change default keybindingsRoberto E. Vargas Caballero2017-01-251-9/+9
| | | | | | | CTRL+SHIFT is an impossible combination in the terminal world (0x20 | x & 0x1F), so it is perfect to be used for internals shortcuts of terminals, and being a double combination reduces the prossibility of having comflicts.
* Split X-specific code into x.cMichael Forney2017-01-206-1994/+2168
|
* Move column and row default numbers into config.hfpqc2016-12-162-2/+7
|
* Revert "Initial font size issue."Roberto E. Vargas Caballero2016-11-241-3/+0
| | | | This reverts commit 424202798b02554092ba84dd59fb7b79b59b7b75.
* Fixed 'missing glyph doesn't use fontconfig config substitutions' bugSpencer Phippen2016-11-241-3/+19
| | | | | | | | | | | | | | | | XftFontMatch does display-specific font configuration (commit 528241a). Nice. Unfortunately, when we switched from FcFontMatch, we also stopped storing the post-Fc{Config,Default}Substitute FcPattern for future lookups. The result is that if a glyph isn't found in the primary font, secondary font lookups use the original FcPattern, not the configured one. If you have custom fontconfig rules (like me), this can be disappointing. I basically just copied the guts out of XftFontMatch[1] and saved the intermediate configured FcPattern. Could be related to the bug that inspired commit 4242027. [1]: https://cgit.freedesktop.org/xorg/lib/libXft/tree/src/xftfont.c
* make the various combinations of arrow keys and shift/control/meta workManuel Tobias Schiller2016-11-141-4/+20
| | | | | | | | | | When using st with screen, I've bound next, prev, new screen to combinations like Ctrl-Alt-Right,Left,Down; xterm and (u)rxvt work fine when this combination of modifiers is pressed, st does not seem to transport all of them; a single modifier key is fine (e.g. Ctrl-Up, Alt-Down etc., but combinations are not). While I'm not terribly familiar with this, I have tried to hack config.h in a more or less systematic way to generate the expected sequences.
* Initial font size issue.ian@remmler.org2016-11-141-0/+3
| | | | | | | | | | | | | | | Hi, When I specify a font by point size (I'm using "Inconsolata:size=12"), characters that are substituted from another font because they are not in the main one appear too small. Doing a zoom reset fixes it. For example: Before: http://i.imgur.com/G4Mfv4X.png After: http://i.imgur.com/PMDhfQA.png I found that adding the pixel size (acquired from the initial font load) to the pattern then reloading the font fixes the problem. I'm not sure if this is a proper fix, though.
remember that computers suck.