aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* base64dec: don't read out of boundsAvi Halachmi (:avih)2019-11-101-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously, base64dec checked terminating input '\0' every 4 calls to base64dec_getc, where the latter progressed one or more chars on each call, and could read past '\0' in the way it was used. The input to base64dec currently comes only from OSC 52 escape seq (copy to clipboard), and reading past '\0' or even past the buffer boundary was easy to trigger. Also, even if we could trust external input to be valid base64, there are different base64 standards, and not all of them require padding to 4 bytes blocks (using trailing '=' chars). It didn't affect short OSC 52 strings because the buffer is initialized to 0's, so typically it did stop within the buffer, but if the string was trimmed to fit (the buffer is 512 bytes) then it did also read past the end of the buffer, and the decoded suffix ended up arbitrary. This patch makes base64dec_getc not progress past '\0', and instead produce fake trailing padding of '='. Additionally, at base64dec, if padding is detected at the first or second byte of a quartet, then we identify it as invalid and abort (a valid quartet has at least two leading non-padding bytes).
* Fix tmux terminfo extensions Se and SsSebastian J. Bronner2019-11-051-2/+2
| | | | | | | | | | | The tmux terminfo extensions Ss and Se are currently specified as booleans in `st.info`. They should be strings. See https://github.com/tmux/tmux/blob/eeedb43ae847a0a692ceea965f7556e84bca4fd0/tty-term.c lines 254 and 265. I have used the values from https://invisible-island.net/ncurses/terminfo.src.html#toc-_S_I_M_P_L_E_T_E_R_M for this patch.
* apply hints before initial mapping (ICCCM)Ingo Lohmar2019-10-261-1/+1
| | | | | | | | | For WM_CLASS this is mentioned in the ICCCM docs https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.2.5 (third sentence). When changing the WM_CLASS from the command line, this is necessary for window managers to pick it up before applying class-based rules.
* mouse shortcuts: allow using forcemousemod (e.g. shift)Avi Halachmi (:avih)2019-10-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The recent mouse shurtcuts commits allow customization, but ignore forcemousemod mask (default: shift) as a modifier, for no good reason other than following the behavior of the KB shortcuts. Allow using forcemousemod too, which now can be used to invoke different shortcuts, though the automatic effect of forcemousemod will be lost for buttons which use mask with forcemousemod. E.g. the default is: static uint forcemousemod = ShiftMask; ... { XK_ANY_MOD, Button4, ttysend, {.s = "\031"} }, ... where ttysend will be invoked for button4 with any mod when not in mouse mode, and with shift when in mouse mode. Now it's possible to do this: { ShiftMask, Button4, ttysend, {.s = "foo"} }, { XK_ANY_MOD, Button4, ttysend, {.s = "\031"} }, Which will invoke ttysend("foo") while shift is held and ttysend("\031") otherwise. Shift still overrides mouse mode, but will now send "foo". Previously with this setup the second binding was always invoked because the forceousemod mask was always removed from the event. Buttons which don't use forcemousemod behave the same as before. This is useful e.g. for the scrollback mouse patch, which wants to configure shift+wheel for scrollback, while keeping the normal behavior without shift.
* mouse shortcuts: don't hardcode selpasteAvi Halachmi (:avih)2019-10-132-12/+26
| | | | | | | | Because selpaste is activated on release, a release flag was added to mouse shortcuts which controls whether activation is on press/release, and selpaste binding to button2 was moved to config.h . button1 remains the only hardcoded mouse button - for selection + copy.
* mouse shortcuts: allow override for all shortcutsAvi Halachmi (:avih)2019-10-132-13/+13
| | | | | | | | | | | | | | | Allow forceselmod to override all mouse shortcuts rather than only selection, and rename it to forcemousemod as it's now more appropriate. This will affect mouse shortcuts which use mask other than XK_ANY_MOD. This does not affect the default behavior because the default mouse shortcuts (wheel) use XK_ANY_MOD, where forceselmod already activated the override also before this change. Previously, if a mouse shortcut was configured with a specific mod and forceselmod was held, then the shortcut did not execute unless the configured mod included forceselmod.
* mouse shortcuts: allow same functions as kb shortcutsAvi Halachmi (:avih)2019-10-133-9/+18
| | | | | | | Previously mouse shortcuts supported only ttywrite. This required adding an "Arg" function ttysend - which does what the original mouse shortcuts did.
* config.def.h: remove crlf value sectionHiltjo Posthuma2019-08-261-4/+0
| | | | | | this is not used anymore. patch sent as an ed script using RFC2549 by k0ga.
* FAQ: add entry about color emoji Xft bugHiltjo Posthuma2019-05-171-0/+27
| | | | | This has been asked many times on IRC and the mailinglist. Make it easier to find information about this particular Xft issue by adding it to the FAQ.
* selection: fix view to match actual selection on first cellAvi Halachmi (:avih)2019-04-141-1/+1
|
* revert part of commit add0211522737b79dad990ccd65c8af63b5cc1ddHiltjo Posthuma2019-03-153-7/+5
| | | | | | | | | | "use iswspace()/iswpunct() to find word delimiters this inverts the configuration logic: you no longer provide a list of delimiters -- all space and punctuation characters are considered delimiters, unless listed in extrawordchars." Feedback from IRC and personal preference.
* dont print color warning on color reset OSC 104 without parameterHiltjo Posthuma2019-03-151-1/+4
| | | | | | also print explicitly "(null)" when printf "%s" p=NULL. noticed when exiting mutt: printf '\x1b]104\x07'
* minor code-style, initialize var at the top of functionHiltjo Posthuma2019-03-151-3/+1
|
* config.def.h: tweak extra worddelimitersHiltjo Posthuma2019-03-151-1/+1
| | | | | This changes the selection more like xterm. To test try: "find /" and select a path.
* use iswspace()/iswpunct() to find word delimitersLauri Tirkkonen2019-03-153-5/+7
| | | | | | this inverts the configuration logic: you no longer provide a list of delimiters -- all space and punctuation characters are considered delimiters, unless listed in extrawordchars.
* replace utf8strchr with wcschrLauri Tirkkonen2019-03-153-22/+4
|
* be silent about explicitly unhandled mouse modesLauri Tirkkonen2019-03-131-0/+1
|
* simplify (greedy) font caching allocating a bitHiltjo Posthuma2019-03-031-7/+2
| | | | | | POSIX says: "If ptr is a null pointer, realloc() shall be equivalent to malloc() for the specified size."
* style: remove double empty newlinesHiltjo Posthuma2019-03-032-3/+0
|
* fix use after free in font caching algorithmmagras2019-03-031-6/+9
| | | | | | | | | | | | | | | | | | Current font caching algorithm contains a use after free error. A font removed from `frc` might be still listed in `wx.specbuf`. It will lead to a crash inside `XftDrawGlyphFontSpec()`. Steps to reproduce: $ st -f 'Misc Tamsyn:scalable=false' $ curl https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt Of course, result depends on fonts installed on a system and fontconfig. In my case, I'm getting consistent segfaults with different fonts. I replaced a fixed array with a simple unbounded buffer with a constant growth rate. Cache starts with a capacity of 0, gets increments by 16, and never shrinks. On my machine after `cat UTF-8-demo.txt` buffer reaches a capacity of 192. During casual use capacity stays at 0.
* better Input Method Editor (IME) supportIvan Tham2019-02-123-17/+54
| | | | | | | | | | | | Features: - Allow input methods swap with hotkey (E.g. left ctrl + left shift). - Over-the-spot pre-editing style, pre-edit data placed over insertion point. - Restart IME without segmentation fault. TODO: - Automatically pickup IME if st started before IME
* bump version to 0.8.2Hiltjo Posthuma2019-02-091-1/+1
|
* config: add Shift+Insert as selpaste() againHiltjo Posthuma2019-01-101-0/+1
| | | | | This was changed before in: commit 20f713548de451b67db3306cf8cf7b2f38fee05c on Wed Jan 25 19:17:38 2017
* Let the user specify CPPFLAGSParide Legovini2019-01-101-2/+2
| | | | | | | | | | | This complements the work done in d4928ed, allowing the user to specify the preprocessor flags with the CPPFLAGS environment variable. This is useful for example to specify preprocessor macros with -D. CFLAGS could be used instead, but CPPFLAGS is more correct and is expected to be honored in some cases. For example, the helper scripts to build Debian packages make use of CPPFLAGS, but the variable is currently being ignored unless manually appended to CFLAGS.
* Set the path of pkg-config in a variable instead of hardcoding itParide Legovini2019-01-041-4/+6
| | | | | In this way the path of pkg-config can be overridden from the command line. This is useful for example when cross-compiling.
* Makefile: fix dependencies on config.hHiltjo Posthuma2019-01-041-1/+1
| | | | patch by Younes Khoudli (changed slightly). Thanks
* output child WEXITSTATUS/WTERMSIG on abnormal terminationLauri Tirkkonen2018-12-111-2/+4
|
* fix memory leak in xloadcols()Hiltjo Posthuma2018-11-041-3/+3
| | | | | | reported by Avi Halachmi (:avih)" <avihpit@yahoo.com> patch slightly changed by me.
* st: small typofix in commentHiltjo Posthuma2018-11-041-1/+1
|
* small code-style fixHiltjo Posthuma2018-09-111-1/+2
|
* Remove the ISO 14755 featureQuentin Rameau2018-09-114-32/+0
| | | | | | And move it to the patches section. Keeping it would force to add an exec pledge on OpenBSD, and some people think it's bloated, so bye!
* Revert "Simplify cursor color handling"Hiltjo Posthuma2018-07-171-12/+18
| | | | This reverts commit 1911c9274d9b03f3d7999c6ce26e2d5169642d26.
* Revert "Make cursor follow text color"Hiltjo Posthuma2018-07-172-7/+7
| | | | This reverts commit b51bcd5553af3db394014efbd78acf7828fa48ff.
* Revert "Fix crash when cursor color is truecolor"Hiltjo Posthuma2018-07-171-13/+4
| | | | This reverts commit 5535c1f04c665c05faff2a65d5558246b7748d49.
* Fix crash when cursor color is truecolorJules Maselbas2018-07-151-4/+13
| | | | Reported-by: Ivan Tham <pickfire@riseup.net>
* Make cursor follow text colorJules Maselbas2018-07-142-7/+7
|
* Simplify cursor color handlingJules Maselbas2018-07-141-18/+12
|
* Fix crash on resizeJules Maselbas2018-06-301-4/+8
| | | | | Prevent to realloc xw.specbuc with a negative number of col. Add proper hints for the minimal size, for one character.
* config.mk: remove extra newline before EOFHiltjo Posthuma2018-06-021-1/+0
|
* code-style for pledge(2)Hiltjo Posthuma2018-05-251-4/+4
| | | | feedback from Klemens, thanks
* Pledge on OpenBSDHiltjo Posthuma2018-05-252-0/+14
|
* error message style and use strerror in a few placesHiltjo Posthuma2018-03-292-24/+24
|
* st -v: remove years and copyright textHiltjo Posthuma2018-03-291-1/+1
|
* set sel.alt in selstart instead of selextendDaniel Tameling2018-03-291-1/+1
|
* bump version to 0.8.1Hiltjo Posthuma2018-03-201-1/+1
|
* fix regression by selecting clipboard textHiltjo Posthuma2018-03-201-0/+3
| | | | | | | "restore the old behaviour that the primary doesn't get deleted by a simple left click" Patch by Daniel Tameling <tamelingdaniel@gmail.com>, thanks!
* don't modify argv, use a counterHiltjo Posthuma2018-03-201-10/+12
| | | | | on some platforms (OpenBSD) this changes the exposed argv in tools using the kvm_* interface, such as ps and pgrep.
* selextend: clarify: !sel.mode == SEL_IDLEHiltjo Posthuma2018-03-171-1/+1
|
* clipcopy: no need to check for free(NULL), set to NULL after freeHiltjo Posthuma2018-03-171-2/+2
|
* minor code-style: whitespace fixesHiltjo Posthuma2018-03-161-2/+1
|
remember that computers suck.