aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjamin <acdimalev@gmail.com>2021-12-29 09:07:17 -0800
committerRomain Gonçalves <me@rgoncalves.se>2024-05-12 21:20:50 +0200
commite3bbca290b0549efc517fbe7535959f63531e801 (patch)
tree5e5b57a3975a16b487b9655c2aff2120bec46492
parentafaca11e795f36dd4fb4743292318e3df39ccabf (diff)
downloadst-e3bbca290b0549efc517fbe7535959f63531e801.tar.gz
Fix overtyping wide characters.
Overtyping the first half of a wide character with the second half of a wide character results in display garbage. This is because the trailing dummy is not cleaned up. i.e. ATTR_WIDE, ATTR_WDUMMY, ATTR_WDUMMY Here is a short script for demonstrating the behavior: #!/bin/sh alias printf=/usr/bin/printf printf こんにちは!; sleep 2 printf '\x1b[5D'; sleep 2 printf へ; sleep 2 printf ' '; sleep 2 echo
-rw-r--r--st.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/st.c b/st.c
index de2dd0e..51049ba 100644
--- a/st.c
+++ b/st.c
@@ -2507,6 +2507,10 @@ check_control_code:
if (width == 2) {
gp->mode |= ATTR_WIDE;
if (term.c.x+1 < term.col) {
+ if (gp[1].mode == ATTR_WIDE && term.c.x+2 < term.col) {
+ gp[2].u = ' ';
+ gp[2].mode &= ~ATTR_WDUMMY;
+ }
gp[1].u = '\0';
gp[1].mode = ATTR_WDUMMY;
}
remember that computers suck.