aboutsummaryrefslogtreecommitdiffstats
path: root/dwm.c
Commit message (Collapse)AuthorAgeFilesLines
* do not call signal-unsafe function inside sighanlderNRK2022-07-151-2/+2
| | | | | die() calls vprintf, fputc and exit; none of these are async-signal-safe, see `man 7 signal-safety`.
* use named parameter for func prototypeNRK2022-07-151-2/+2
| | | | all the other prototypes use names.
* manage: Make sure c->isfixed is applied before floating checksChris Down2022-04-261-0/+1
| | | | | | | | | | Commit 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size hints") mistakenly removed an early size hints update that's needed to populate c->isfixed for floating checks at manage() time. This resulted in fixed (size hint min dimensions == max dimensions) subset of windows not floating when they should. See https://lists.suckless.org/dev/2204/34730.html for discussion.
* Revert "manage: For isfloating/oldstate check/set, ensure trans client ↵Hiltjo Posthuma2022-04-261-1/+1
| | | | | | | | | actually exists" This reverts commit bece862a0fc4fc18ef9065b18cd28e2032d0d975. It caused a regression, for example: https://lists.suckless.org/hackers/2203/18220.html
* Update monitor positions also on removalSanttu Lakkala2022-04-161-34/+34
| | | | | | | | | When monitors are removed, the coordinates of existing monitors may change, if the removed monitors had smaller coordinates than the remaining ones. Remove special case handling so that the same update-if-necessary loop is run also in the case when monitors are removed.
* manage: propertynotify: Reduce cost of unused size hintsChris Down2022-04-161-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch defers all size hint calculations until they are actually needed, drastically reducing the number of calls to updatesizehints(), which can be expensive when called repeatedly (as it currently is during resizes). In my unscientific testing this reduces calls to updatesizehints() by over 90% during a typical work session. There are no functional changes for users other than an increase in responsiveness after resizes and a reduction in CPU time. In slower environments or X servers, this patch also offers an improvement in responsiveness that is often tangible after resizing a client that changes hints during resizes. There are two main motivations to defer this work to the time of hint application: 1. Some clients, especially terminals using incremental size hints, resend XA_WM_NORMAL_HINTS events on resize to avoid fighting with the WM or mouse resizing. For example, some terminals like urxvt clear PBaseSize and PResizeInc during XResizeWindow and restore them afterwards. For this reason, after the resize is concluded, we typically receive a backlogged XA_WM_NORMAL_HINTS message for each update period with movement, which is useless. In some cases one may get hundreds or thousands of XA_WM_NORMAL_HINTS messages on large resizes, and currently all of these result in a separate updatesizehints() call, of which all but the final one are immediately outdated. (We can't just blindly discard these messages during resizes like we do for EnterNotify, because some of them might actually be for other windows, and may not be XA_WM_NORMAL_HINTS events.) 2. For users which use resizehints=0 most of these updates are unused anyway -- in the normal case where the client is not floating these values won't be used, so there's no need to calculate them up front. A synthetic test using the mouse to resize a floating terminal window from roughly 256x256 to 1024x1024 and back again shows that the number of calls to updatesizehints() goes from over 500 before this patch (one for each update interval with movement) to 2 after this patch (one for each hint application), with no change in user visible behaviour. This also reduces the delay before dwm is ready to process new events again after a large resize on such a client, as it avoids the thundering herd of updatesizehints() calls when hundreds of backlogged XA_WM_NORMAL_HINTS messages appear at once after a resize is finished.
* manage: For isfloating/oldstate check/set, ensure trans client actually existsMiles Alan2022-03-131-1/+1
| | | | | | | | In certain instances trans may be set to a window that doesn't actually map to a client via wintoclient; in this case it doesn't make sense to set isfloating/oldstate since trans is essentially invalid in that case / correlates to the above condition check where trans is set / XGetTransientForHint is called.
* fix mem leak in cleanup()NRK2022-03-131-0/+1
| | | | | | | | maybe leak isn't the best word, given that the object lives for the entire duration of the program's lifetime. however, all elements of scheme are free-ed, can't think of any reason why scheme itself should be an exception.
* drawbar: Don't expend effort drawing bar if it is occludedChris Down2021-12-191-0/+3
| | | | | | | | | | | | | | | | | I noticed that a non-trivial amount of dwm's work on my machine was from drw_text, which seemed weird, because I have the bar disabled and we only use drw_text as part of bar drawing. Looking more closely, I realised that while we use m->showbar when updating the monitor bar margins, but don't skip actually drawing the bar if it is hidden. This patch skips drawing it entirely if that is the case. On my machine, this takes 10% of dwm's on-CPU time, primarily from restack() and focus(). When the bar is toggled on again, the X server will generate an Expose event, and we'll redraw the bar as normal as part of expose().
* Add a configuration option for fullscreen lockingQuentin Rameau2021-07-141-1/+1
| | | | | Some people are annoyed to have this new behaviour forced for some application which use fake fullscreen.
* Do not allow focus to drift from fullscreen client via focusstack()Chris Down2021-03-291-1/+1
| | | | | | | | | | | | | It generally doesn't make much sense to allow focusstack() to navigate away from the selected fullscreen client, as you can't even see which client you're selecting behind it. I have had this up for a while on the wiki as a separate patch[0], but it seems reasonable to avoid this behaviour in dwm mainline, since I'm struggling to think of any reason to navigate away from a fullscreen client other than a mistake. 0: https://dwm.suckless.org/patches/alwaysfullscreen/
* Fix x coordinate calculation in buttonpress.Ian Remmler2020-08-211-1/+1
|
* dwm crashes when opening 50+ clients (tile layout)bakkeby2020-04-251-2/+4
| | | | | | | | Many users new to dwm find themselves caught out by being kicked out to the login manager (dwm crashing) when they open 50+ clients for demonstration purposes. The number of clients reported varies depending on the resolution of the monitor. The cause of this is due to how the default tile layout calculates the height of the next client based on the position of the previous client. Because clients have a minimum size the (ty) position can exceed that of the window height, resulting in (m->wh - ty) becoming negative. The negative height stored as an unsigned int results in a very large height ultimately resulting in dwm crashing. This patch adds safeguards to prevent the ty and my positions from exceeding that of the window height.
* drawbar: Don't shadow sw globalChris Down2020-04-221-4/+4
| | | | | | | This jarred me a bit while reading the code, since "sw" usually refers to the global screen geometry, but in drawbar() only it refers to text-related geometry. Renaming it makes it more obvious that these are not related.
* getatomprop: Add forward declarationChris Down2020-04-221-0/+1
| | | | | No functional changes, but for every other function we have a forward declaration here. getatomprop should be no exception.
* setmfact: Unify bounds for compile-time and runtime mfactChris Down2020-04-201-1/+1
| | | | | | | | | | | | | | | | | | | | There are two places that mfact can be set: - In the mfact global, which is defined at compile time and passed into m->mfact during monitor setup. No bounds checks are performed, but the comment alongside it says that valid values are [0.05..0.95]: static const float mfact = 0.55; /* factor of master area size [0.05..0.95] */ - By setmfact, which adjusts m->mfact at runtime. It also does some minimum and maximum bounds checks, allowing [0.1..0.9]. Values outside of that range are ignored, and mfact is not adjusted. These different thresholds mean that one cannot setmfact 0.95 or 0.05, despite the comment above that lists the legal range for mfact. Clarify this by enforcing the same bounds in setmfact at runtime as those listed for mfact at compile time.
* pledge: add rpath promise for the ugly Xft font fallbackHiltjo Posthuma2018-06-021-1/+1
|
* Pledge on OpenBSDKlemens Nanni2018-05-251-0/+4
|
* Function declarations in correct order.Christopher Drelich2018-05-121-1/+1
| | | | | | | In dwm.c function declarations are in alphabetical order except for updategeom(). There doesn't appear to be any reason for this, so this patch corrects that, and now all function declarations are in alphabetical order.
* All functions in alphabetical order except for this one.Christopher Drelich2018-03-141-9/+9
|
* ColBorder has been moved to the enum with ColFg and ColBg.Christopher Drelich2018-03-141-1/+0
|
* dont NUL terminate _NET_WM_NAMEHiltjo Posthuma2017-12-271-1/+1
| | | | | | | | | | | | | | | Reported by Kernc, thanks! "This makes a particular program that uses libwnck [1] fail after: Wnck-WARNING **: Property _NET_WM_NAME contained invalid UTF-8 in this code [2] because the returned string contains a '\0' and the documentation for g_utf8_validate() [3] explicitly states that when string length is provided, no nul bytes are allowed." It is not entirely clear it is incorrect, other WM's seem to not NUL terminate it either though.
* sync dmenu drw.{c,h} code: use Clr* (was Scm)Hiltjo Posthuma2017-11-031-2/+2
|
* gettextprop: check result of XGetTextProperty (undefined behaviour for XFree)Hiltjo Posthuma2017-11-031-2/+1
|
* Set class name on status barOmar Sandoval2017-11-031-0/+2
| | | | | This is useful for configuring compositors to ignore the status bar window.
* simplify isfixed conditionsDaniel Cousens2017-10-111-2/+1
|
* yet another cleanupAnselm R Garbe2017-05-081-34/+34
| | | | | The previous patches introduced some unclean space-based indentation patterns. This patch fixes them.
* Don't restrict snap in mousemoveMarkus Teich2017-03-281-14/+11
| | | | | This also fixes a bug where client windows only switch to floating mode when the mouse is dragged in one specific direction.
* Button passthrough when client is not focusedMarkus Teich2017-03-281-10/+11
| | | | | | | | | | | Before this change it is not possible to press a button in a client on the first click if the client is not yet focused. The first click on the button would only focus the client and a second click on the button is needed to activate it. This situation can occur when moving the mouse over a client (therefore focusing it) and then moving the focus to another client with keyboard shortcuts. After this commit the behavior is fixed and button presses on unfocused clients are passed to the client correctly.
* cleanupMarkus Teich2017-03-281-34/+30
| | | | | | | | | | | | | | - unify multi-line expression alignment style. - unify multi-line function call alignment style. - simplify client moving on monitor count decrease. - clarify comment for focusin(). - remove old confusing comment about input focus fix in focusmon(). The explanation is already in the old commit message, so no need to keep it in the code. - remove old comment describing even older state of the code in focus(). - unify comment style. - break up some long lines. - fix some typos and grammar.
* applied Markus' tagset purge of alternative view on _NET_ACTIVE_WINDOW eventAnselm R Garbe2016-12-051-20/+18
|
* applied Ivan Delalande's NET_SUPPORTING_WM_CHECK patch for gtk3 compatibilityAnselm R Garbe2016-12-051-2/+14
|
* applied Markus' decouple color-scheme patchAnselm R Garbe2016-12-051-5/+7
|
* applied Markus' clarify status text padding patchAnselm R Garbe2016-12-051-2/+2
|
* die() consistency: always add newlineHiltjo Posthuma2016-08-121-5/+5
|
* import new drw from libsl and minor fixes.Markus Teich2016-06-261-46/+39
| | | | | - better scaling for occupied tag squares. - draw statusline first to omitt some complicated calculations.
* Configure geometry before applying rulesEric Pruitt2016-06-241-6/+7
| | | | | | Configuring geometry before applying rules makes it possible to have more complex constraints in applyrules that depend on the initial window dimensions and location.
* fix fullscreen clients not resized on X display resolution changeHiltjo Posthuma2015-12-191-1/+6
| | | | patch provided by Bert Münnich <ber.t_AT_posteo.de>, thanks!
* code-style consistencyHiltjo Posthuma2015-11-081-433/+503
|
* unboolificationHiltjo Posthuma2015-11-081-71/+70
|
* sort include + whitespace fixHiltjo Posthuma2015-11-081-3/+3
|
* separate program-specific c99 bool and X11Hiltjo Posthuma2015-11-081-70/+72
| | | | | True, False are X11-specific (int), make sure to use c99 stdbool for program-specific things.
* setfullscreen: don't process the property twiceQuentin Rameau2015-11-071-2/+2
| | | | | | | | | | Some clients try to set _NET_WM_STATE_FULLSCREEN even when the window is already in fullscreen. For example, c->oldstate was set two times in a raw and window would then always be floating. We must check that it's not the case before processing it. (original patch modified with suggestion from Markus Teich <markus.teich@stusta.mhn.de>)
* sync updated drw code from dmenuHiltjo Posthuma2015-10-201-4/+6
| | | | | | important: - drw_rect: didn't use w and h, change the dwm code accordingly. - drw_text: text is NULL is not allowed, use drw_rect().
* dwm: use ecalloc, prevent theoretical overflowHiltjo Posthuma2015-10-201-6/+3
|
* cleanup, dont use c++ style commentsHiltjo Posthuma2015-10-201-4/+4
| | | | | | - signal: print error string. - die: start message with lower-case (consistency). - bump version to 2015.
* dwm: cleanup: free schemes and cursors as arrayHiltjo Posthuma2015-10-201-9/+8
|
* Add Xft and follback-fonts support to graphics libEric Pruitt2015-03-131-10/+10
|
* applied Hiltjo's resize/move limitationAnselm R Garbe2014-08-111-2/+11
| | | | | | "Limit the amount of updates when resizing or moving a window in floating mode to 60 times per second. This makes resizing and moving alot smoother and by limiting it it also uses alot less resources on my machine.
* same as before with dwm.c as wellAnselm R Garbe2014-05-291-1/+1
|
remember that computers suck.